<html>
<head><meta charset="utf-8"><title>milestone adjustments · t-compiler/wg-nll · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/index.html">t-compiler/wg-nll</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html">milestone adjustments</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="136002220"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136002220" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136002220">(Oct 17 2018 at 21:30)</a>:</h4>
<p>I was asked to pare down the Rust 2018 RC 2 blockers to the <strong>true blockers</strong>. As a result, I moved:</p>
<ul>
<li>all diagnostic issues to Rust 2018 Release</li>
<li>the diagnostic review <a href="https://github.com/rust-lang/rust/issues/54528" target="_blank" title="https://github.com/rust-lang/rust/issues/54528">https://github.com/rust-lang/rust/issues/54528</a> (which may, of course, reveal soundness issues)</li>
</ul>



<a name="136004425"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136004425" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136004425">(Oct 17 2018 at 22:11)</a>:</h4>
<p>I do wonder whether, once PR <a href="https://github.com/rust-lang/rust/issues/55134" target="_blank" title="https://github.com/rust-lang/rust/issues/55134">#55134</a> lands, if there <em>some</em> faster methodology we could use to try to identify the potential soundness issues</p>



<a name="136004432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136004432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136004432">(Oct 17 2018 at 22:11)</a>:</h4>
<p>ie.. a lighter weight, more directed version of <a href="https://github.com/rust-lang/rust/issues/54528" target="_blank" title="https://github.com/rust-lang/rust/issues/54528">#54528</a> for the RC2</p>



<a name="136004485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136004485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136004485">(Oct 17 2018 at 22:12)</a>:</h4>
<p>I think my biggest fear is the set of tests where a whole bunch of distinct cases are all in one file</p>



<a name="136004509"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136004509" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136004509">(Oct 17 2018 at 22:13)</a>:</h4>
<p>If the different cases were in different files, then we'd immediately see the instances where AST-borrowck flagged an error and MIR-borrowck did not (and then review those)</p>



<a name="136004519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136004519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136004519">(Oct 17 2018 at 22:13)</a>:</h4>
<p>but the way things stand... its a bit harder to tease out the deltas from the diffs of the .stderr files</p>



<a name="136004578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136004578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136004578">(Oct 17 2018 at 22:14)</a>:</h4>
<p>I guess this is my long winded way of saying: I don't disagree with the milestone adjustment for <a href="https://github.com/rust-lang/rust/issues/54528" target="_blank" title="https://github.com/rust-lang/rust/issues/54528">#54528</a>, based on an assumption that chances are high that we've already identified the soundness issues that were going to be uncovered via that methodology</p>



<a name="136004600"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136004600" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136004600">(Oct 17 2018 at 22:15)</a>:</h4>
<p>and therefore the main things remaining are just completeness (which wont be much, if anything) and diagnostic quality (which given the current state of things, should not be an RC2 blocker IMO).</p>



<a name="136030494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136030494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136030494">(Oct 18 2018 at 09:32)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> so the <a href="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen+is%3Aissue+milestone%3A%22Edition+2018+RC+2%22+label%3AA-nll+" target="_blank" title="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen+is%3Aissue+milestone%3A%22Edition+2018+RC+2%22+label%3AA-nll+">current list of blockers</a> is .. not short</p>



<a name="136030496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136030496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136030496">(Oct 18 2018 at 09:32)</a>:</h4>
<p>NLL blockers, that is</p>



<a name="136030512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136030512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136030512">(Oct 18 2018 at 09:33)</a>:</h4>
<p>I think some of them should be "demoted"</p>



<a name="136030645"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136030645" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136030645">(Oct 18 2018 at 09:36)</a>:</h4>
<p>Some candidates to be demoted to release milestone:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/54940" target="_blank" title="https://github.com/rust-lang/rust/issues/54940">#54940</a> -- user annotations captured post normalization -- fix is going to be non-trivial</li>
<li><a href="https://github.com/rust-lang/rust/issues/47184" target="_blank" title="https://github.com/rust-lang/rust/issues/47184">#47184</a> -- still more edge cases to cover I thnk</li>
<li><a href="https://github.com/rust-lang/rust/issues/54105" target="_blank" title="https://github.com/rust-lang/rust/issues/54105">#54105</a> -- not quite sure how to even reproduce yet</li>
</ul>
<p>Some things I am unsure about:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/54692" target="_blank" title="https://github.com/rust-lang/rust/issues/54692">#54692</a> -- <span class="user-mention" data-user-id="116925">@mikhail-m1</span> has been working at it, they left a message, I will try to get them unstuck and/or finish today</li>
<li><a href="https://github.com/rust-lang/rust/issues/54142" target="_blank" title="https://github.com/rust-lang/rust/issues/54142">#54142</a> -- an ICE, in theory <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> is assigned but I know they are busy, maybe it's an easy fix?</li>
</ul>
<p>The rest have pending fixes and/or are deep in progress:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/54570" target="_blank" title="https://github.com/rust-lang/rust/issues/54570">#54570</a> -- <span class="user-mention" data-user-id="116083">@pnkfelix</span>  is working on complex patterns, status update?</li>
<li><a href="https://github.com/rust-lang/rust/issues/54332" target="_blank" title="https://github.com/rust-lang/rust/issues/54332">#54332</a> -- fixed in my PR</li>
<li><a href="https://github.com/rust-lang/rust/issues/54571" target="_blank" title="https://github.com/rust-lang/rust/issues/54571">#54571</a> -- fixed in my PR<br>
-</li>
</ul>



<a name="136030984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136030984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136030984">(Oct 18 2018 at 09:44)</a>:</h4>
<p>I don’t object to demoting the ones you listed as well as the ones you were less sure about</p>



<a name="136031008"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136031008" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136031008">(Oct 18 2018 at 09:45)</a>:</h4>
<p>I’ll try to have status update on mine later today. #things on plate is reduced but still a lot going on at moment</p>



<a name="136053236"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136053236" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136053236">(Oct 18 2018 at 16:10)</a>:</h4>
<blockquote>
<p>Some candidates to be demoted to release milestone:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/54940" target="_blank" title="https://github.com/rust-lang/rust/issues/54940">#54940</a> -- user annotations captured post normalization -- fix is going to be non-trivial</li>
<li><a href="https://github.com/rust-lang/rust/issues/47184" target="_blank" title="https://github.com/rust-lang/rust/issues/47184">#47184</a> -- still more edge cases to cover I thnk</li>
<li><a href="https://github.com/rust-lang/rust/issues/54105" target="_blank" title="https://github.com/rust-lang/rust/issues/54105">#54105</a> -- not quite sure how to even reproduce yet</li>
</ul>
<p>Some things I am unsure about:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/54692" target="_blank" title="https://github.com/rust-lang/rust/issues/54692">#54692</a> -- <span class="user-mention" data-user-id="116925">@mikhail-m1</span> has been working at it, they left a message, I will try to get them unstuck and/or finish today</li>
<li><a href="https://github.com/rust-lang/rust/issues/54142" target="_blank" title="https://github.com/rust-lang/rust/issues/54142">#54142</a> -- an ICE, in theory <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> is assigned but I know they are busy, maybe it's an easy fix?</li>
</ul>
<p>The rest have pending fixes and/or are deep in progress:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/54570" target="_blank" title="https://github.com/rust-lang/rust/issues/54570">#54570</a> -- <span class="user-mention" data-user-id="116083">@pnkfelix</span>  is working on complex patterns, status update?</li>
<li><a href="https://github.com/rust-lang/rust/issues/54332" target="_blank" title="https://github.com/rust-lang/rust/issues/54332">#54332</a> -- fixed in my PR</li>
<li><a href="https://github.com/rust-lang/rust/issues/54571" target="_blank" title="https://github.com/rust-lang/rust/issues/54571">#54571</a> -- fixed in my PR<br>
-</li>
</ul>
</blockquote>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> I guess starting tomorrow night I will have time to spend on this, we can even go after it together during the conf?</p>



<a name="136172109"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136172109" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136172109">(Oct 20 2018 at 15:02)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> I guess you pointed to the wrong issue, is <a href="https://github.com/rust-lang/rust/issues/54124" target="_blank" title="https://github.com/rust-lang/rust/issues/54124">#54124</a> the one we are talking about, right?</p>



<a name="136172114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136172114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136172114">(Oct 20 2018 at 15:02)</a>:</h4>
<p>the last 2 numbers are flipped</p>



<a name="136275371"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136275371" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136275371">(Oct 22 2018 at 15:39)</a>:</h4>
<p><span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> where did I flip the numbers?</p>



<a name="136275373"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136275373" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136275373">(Oct 22 2018 at 15:39)</a>:</h4>
<p>I do that a lot</p>



<a name="136291601"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136291601" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136291601">(Oct 22 2018 at 20:08)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> don't worry is not important :)</p>



<a name="136291621"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/milestone%20adjustments/near/136291621" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/milestone.20adjustments.html#136291621">(Oct 22 2018 at 20:09)</a>:</h4>
<blockquote>
<p>Some candidates to be demoted to release milestone:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/54940" target="_blank" title="https://github.com/rust-lang/rust/issues/54940">#54940</a> -- user annotations captured post normalization -- fix is going to be non-trivial</li>
<li><a href="https://github.com/rust-lang/rust/issues/47184" target="_blank" title="https://github.com/rust-lang/rust/issues/47184">#47184</a> -- still more edge cases to cover I thnk</li>
<li><a href="https://github.com/rust-lang/rust/issues/54105" target="_blank" title="https://github.com/rust-lang/rust/issues/54105">#54105</a> -- not quite sure how to even reproduce yet</li>
</ul>
<p>Some things I am unsure about:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/54692" target="_blank" title="https://github.com/rust-lang/rust/issues/54692">#54692</a> -- <span class="user-mention" data-user-id="116925">@mikhail-m1</span> has been working at it, they left a message, I will try to get them unstuck and/or finish today</li>
<li><a href="https://github.com/rust-lang/rust/issues/54142" target="_blank" title="https://github.com/rust-lang/rust/issues/54142">#54142</a> -- an ICE, in theory <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> is assigned but I know they are busy, maybe it's an easy fix?</li>
</ul>
<p>The rest have pending fixes and/or are deep in progress:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/54570" target="_blank" title="https://github.com/rust-lang/rust/issues/54570">#54570</a> -- <span class="user-mention" data-user-id="116083">@pnkfelix</span>  is working on complex patterns, status update?</li>
<li><a href="https://github.com/rust-lang/rust/issues/54332" target="_blank" title="https://github.com/rust-lang/rust/issues/54332">#54332</a> -- fixed in my PR</li>
<li><a href="https://github.com/rust-lang/rust/issues/54571" target="_blank" title="https://github.com/rust-lang/rust/issues/54571">#54571</a> -- fixed in my PR<br>
-</li>
</ul>
</blockquote>
<p>but it was here you said <a href="https://github.com/rust-lang/rust/issues/54142" target="_blank" title="https://github.com/rust-lang/rust/issues/54142">#54142</a> and was <a href="https://github.com/rust-lang/rust/issues/54124" target="_blank" title="https://github.com/rust-lang/rust/issues/54124">#54124</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>